[ESI][Runtime] Generate C++ header files for constants #7517
Conversation
teqdruid
force-pushed
the
teqdruid/esirt/cppgen
branch
from
0e1b7b3
to
f5a7f62
Compare
| s = f""" | ||
| /// Generated header for {system_name} module {module_info.name}. | ||
| #pragma once | ||
| #include "types.h" |
There was a problem hiding this comment.
Way too generic, and alias-prone. ESITypes.h at a minimum. Ideally, there'd be some include path here (#include "ESI/types.h").
There was a problem hiding this comment.
The idea is that users could choose the name of the folder in which to output the files. (e.g. ESI/ or <system-specific-name>/) so the output file would be something like ESI/types.h.
| "--platform", | ||
| type=str, | ||
| help="Name of backend for live accelerator connection.") |
There was a problem hiding this comment.
platform or backend? Seems like it's referring to backends, but maybe im misunderstanding the scope of backends/(platforms?).
There was a problem hiding this comment.
Backend ~= platform. Technically, a backend is a particular runtime implementation of an FPGA platform. I do expect a 1:1 mapping in most cases. I tend to refer to platform for anything user facing.
Start of static C++ header file generation. Just integer constants for now. Can work off of any manifest and will even connect to a live accelerator and read the manifest from there.
Generates a
types.hfile and one per module listed in the manifest. Inside the module header file, generates one class per module and adds the constants to that class. Puts everything in a namespace specified by the user assystem_name.